Skip to content

feat: add config root support#205

Closed
stevenh wants to merge 1 commit into
dropbox:masterfrom
stevenh:feat/config-root
Closed

feat: add config root support#205
stevenh wants to merge 1 commit into
dropbox:masterfrom
stevenh:feat/config-root

Conversation

@stevenh

@stevenh stevenh commented Nov 21, 2023

Copy link
Copy Markdown

Add support for config root as introduced in later version of the SDK.

The also fixes an API breakage introduced by v6.0.5 of the SDK, specifically dbx.Upload now takes a UploadArg not a CommitInfo.

This bumps dependent packages:

  • github.com/dropbox/dropbox-sdk-go-unofficial/v6 to v6.0.5
  • golang.org/x/oauth2 to v0.14.0

Add support for config root as introduced in later version of the SDK.

The also fixes an API breakage introduced by v6.0.5 of the SDK,
specifically dbx.Upload now takes a UploadArg not a CommitInfo.

This bumps dependent packages:
* github.com/dropbox/dropbox-sdk-go-unofficial/v6 to v6.0.5
* golang.org/x/oauth2 to v0.14.0
@jaraco

jaraco commented Jun 19, 2024

Copy link
Copy Markdown

Does this change address any of the open issues?

@stevenh

stevenh commented Jun 19, 2024

Copy link
Copy Markdown
Author

I didn't raise an issue as it's a new feature.

@AndreyVMarkelov

Copy link
Copy Markdown
Contributor

Thanks for the PR. This has been superseded by current master.

dbxcli now auto-detects the account root namespace and applies it with Config.WithRoot(...) for personal/team-access commands, with coverage in cmd/root_test.go. The Dropbox SDK has also been upgraded past the version targeted here; current master uses github.com/dropbox/dropbox-sdk-go-unofficial/v6 v6.2.0.

Given that the branch now conflicts with current auth/root setup and the core SDK upgrade/root-namespace behavior is already present, I am closing this PR as obsolete.

@stevenh stevenh deleted the feat/config-root branch July 3, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants